[BugFix] Prevent crash if type mismatch in BinaryDictPageDecoder (bac…

…kport #52036) (backport #52062) (#52068) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
StarRocks · Oct 17, 2024 · 1fa1108 · 1fa1108
1 parent 818f13a
commit 1fa1108
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/be/src/storage/rowset/binary_dict_page.cpp b/be/src/storage/rowset/binary_dict_page.cpp
@@ -261,7 +261,9 @@ Status BinaryDictPageDecoder<Type>::next_batch(const SparseRange<>& range, Colum
  }
  }
 
- CHECK(dst->append_strings_overflow(slices, _max_value_legth));
+ bool ok = dst->append_strings_overflow(slices, _max_value_legth);
+ DCHECK(ok) << "append_strings_overflow failed";
+ RETURN_IF(!ok, Status::InternalError("BinaryDictPageDecoder::next_batch failed"));
  return Status::OK();
 }