Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StarRocksSinkOptions.java #348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

uicosp
Copy link

@uicosp uicosp commented Mar 27, 2024

auto add __op for primary key table even when user specified sink.properties.columns

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Problem Summary(Required) :

auto add __op for primary key table even when user specified sink.properties.columns,
in case user use a bitmap datatype and need set up sink.properties.columns, may forget to add __op.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

auto add `__op` for primary key table even when user specified `sink.properties.columns`

Signed-off-by: uicosp <[email protected]>

auto add `__op` for primary key table even when user specified `sink.properties.columns`

auto add `__op` for primary key table even when user specified `sink.properties.columns`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants