Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] making this version comparison more resilient as it fails issues/41016 #42198

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[BugFix] making this version comparison more resilient as it fails issues/41016 #42198

merged 1 commit into from
Mar 6, 2024

Conversation

fardinsarker
Copy link
Contributor

@fardinsarker fardinsarker commented Mar 6, 2024 •
edited by Astralidea
Loading

Why I'm doing:

Fixed StarRocks/dbt-starrocks#23 which causes problems with version 3.2
Used to spit out
'>' not supported between instances of 'int' and 'str'

What I'm doing:

Fixes #issue
StarRocks/dbt-starrocks#23

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@imay
Copy link
Contributor

imay commented Mar 6, 2024

@fardinsarker thank you for this contribution, can you sign the CLA and sign-off this fix by git commit -s?

@fardinsarker fardinsarker mentioned this pull request Mar 6, 2024
Open
@fardinsarker fardinsarker force-pushed the fix/make_resilient_dbt_is_before_version branch from e1dcb51 to 531fe9d Compare March 6, 2024 09:11
@github-actions github-actions bot added the 3.2 label Mar 6, 2024
@fardinsarker fardinsarker force-pushed the fix/make_resilient_dbt_is_before_version branch from 531fe9d to 22f2284 Compare March 6, 2024 10:07
@github-actions github-actions bot added 3.2 and removed 3.2 labels Mar 6, 2024
@fardinsarker fardinsarker force-pushed the fix/make_resilient_dbt_is_before_version branch from 22f2284 to cf6c9c9 Compare March 6, 2024 10:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@imay imay merged commit 81219ae into StarRocks:main Mar 6, 2024
37 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Mar 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

backport branch-3.2

🟠 Pending

  • Backport to branch branch-3.2 in progress

mergify bot pushed a commit that referenced this pull request Mar 6, 2024
@fardinsarker @mergify
[BugFix] making this version comparison more resilient as it fails is…
883a429 
…sues/41016 (#42198)

Fixed #41016 which causes problems with version 3.2
Used to spit out
'>' not supported between instances of 'int' and 'str'
Signed-off-by: Fardin Sarker <[email protected]>
(cherry picked from commit 81219ae)
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

backport branch-3.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Mar 6, 2024
Closed
18 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot added 3.2 and removed 3.2 labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Astralidea Astralidea Astralidea approved these changes

Assignees

@fardinsarker fardinsarker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbt tutorial my_first_dbt_model doesn't work with StarRocks
4 participants
@fardinsarker @CLAassistant @imay @Astralidea