-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase11 #10
base: main
Are you sure you want to change the base?
Phase11 #10
Conversation
Co-authored-by: Mohammad Sadegh Montazeri <[email protected]>
@@ -0,0 +1,84 @@ | |||
name: Release | |||
|
|||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
این اوکیه ولی چرا حالت سادهتر push روی main رو انتخاب نکردی؟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
یکم دست آدم رو بازتر میذاره. مثلا الان تنظیم کردم فقط موقعی که PRمون از phase05 مرج میشه اجرا بشه چون اگه سورس تغییر نکنه ایمیج نهایی هم تکراری میشه و فقط بی دلیل ورژن میخوره.
contents: write | ||
|
||
outputs: | ||
new_tag: ${{ steps.generate_tag.outputs.new_tag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
این کجا استفاده میشه؟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
فعلا جای خاصی استفاده نمیشه اما jobی که کارش tag زدنه به نظرم منطقی باشه تگی که زده رو هم برکردونه.
MINOR_STRING_TOKEN: feat | ||
MAJOR_STRING_TOKEN: BREAKING | ||
|
||
- name: Pure version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
چه نیازی به این کار هست؟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
منظورتون pure_version هست؟ راستش چون actionی که استفاده کردم خودش tag میزنه و push میکنه و من میخواستم تگ ها قبلشون v داشته باشن WITH_V رو روشن گذاشتم اما ایمیج های داکر رو نمیخواستم v داشته باشن برای همین با sed حرف v رو از اول tag حذف میکنم و برمیگردونم. البته در نهایت هردو تگ با و بدون v رو گذاشتم برای داکر.
No description provided.