-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NotFound component #9
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 80.90% 81.06% +0.17%
==========================================
Files 123 125 +2
Lines 2381 2434 +53
Branches 270 276 +6
==========================================
+ Hits 1926 1973 +47
- Misses 434 440 +6
Partials 21 21
Continue to review full report in Codecov by Sentry.
|
12074ec
to
15e492d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @arkadiuszbachorski; I'll defer to @NikolaiMadlener & @ThomasKaar for a detailed review.
d00ede4
to
30f3c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we wanna expose the NotFound
molecule in the /src/index.ts
file?
Otherwise LGTM; thanks @arkadiuszbachorski!
30f3c41
to
4b92108
Compare
Add NotFound component
♻️ Current situation & Problem
NotFound is common pattern. It's worth providing out of the box solution.
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: