Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NotFound component #9

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

arkadiuszbachorski
Copy link
Collaborator

Add NotFound component

♻️ Current situation & Problem

NotFound is common pattern. It's worth providing out of the box solution.

⚙️ Release Notes

  • Add NotFound component

image

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (14cad48) to head (1820d2b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/index.ts 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   80.90%   81.06%   +0.17%     
==========================================
  Files         123      125       +2     
  Lines        2381     2434      +53     
  Branches      270      276       +6     
==========================================
+ Hits         1926     1973      +47     
- Misses        434      440       +6     
  Partials       21       21              
Files with missing lines Coverage Δ
src/molecules/NotFound/NotFound.tsx 100.00% <100.00%> (ø)
src/molecules/NotFound/index.tsx 100.00% <100.00%> (ø)
src/index.ts 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cad48...1820d2b. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arkadiuszbachorski; I'll defer to @NikolaiMadlener & @ThomasKaar for a detailed review.

@arkadiuszbachorski arkadiuszbachorski force-pushed the arek/add-not-found-component branch 2 times, most recently from d00ede4 to 30f3c41 Compare November 5, 2024 20:55
Copy link
Collaborator

@ThomasKaar ThomasKaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@NikolaiMadlener NikolaiMadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we wanna expose the NotFound molecule in the /src/index.ts file?

Otherwise LGTM; thanks @arkadiuszbachorski!

@arkadiuszbachorski arkadiuszbachorski merged commit bb3c96c into main Nov 11, 2024
9 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/add-not-found-component branch November 11, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants