-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Strict Concurrency fix #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this!
Seems like we also need to update the Snapshot tests & other functionality to reflect the concurrency change to make the PR mergable
@PSchmiedmayer the Snapshots test are failing within the CI. If you look at the xcresult bundle, the snapshot images don't differ though. I couldn't reproduce the failure locally. I also tried to regenerate the images (they resulted in the exact same binary representation). |
@Supereg As noted on Slack: I unfortunately don't have a clear idea where this might come from, let me know if you want me to dig deeper into this! |
Maybe we can wait for Xcode 16 beta 4 release today and see if that changes anything? Otherwise, let's discuss other strategies in the meeting later. |
@Supereg I have just installed the Xcode 16 Beta 4 on all macOS runners that we host. |
Just resolved the issue. It seems there is a difference, if the snapshot tests are run on the iOS 18 simulator vs on an iOS 17.5 simulator. The iOS 18 simulator slightly changes shadows around text which made all of the snapshot testing fail. This is now resolved. I added some additional minor changes to the PR, like improving Sendable annotation of |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 80.36% 80.45% +0.10%
==========================================
Files 44 44
Lines 1298 1304 +6
==========================================
+ Hits 1043 1049 +6
Misses 255 255
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you; those look good to me! 🚀
Minor Strict Concurrency fix
♻️ Current situation & Problem
This PR adds a missing Sendable conformance.
⚙️ Release Notes
ValidationEngine
in the environment withVerifiableTextField
for greater flexibility.📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: