-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing decoding times if times was never encoded error #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @apgupta3303 for the PR, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @apgupta3303! I restarted our runners; seems to have been an issue with Xcode 15.3 and the stability to startup the simulator.
The PR and the fix looks good to me 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 52.04% 54.79% +2.75%
==========================================
Files 21 21
Lines 982 982
==========================================
+ Hits 511 538 +27
+ Misses 471 444 -27
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@apgupta3303 Only SwiftLint errors are left (this includes the build errors), please fix them and then you can merge the PR. Thanks for the bugfix! 🚀 |
Fixing Decoding Times Error
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: