Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing decoding times if times was never encoded error #12

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

apgupta3303
Copy link
Contributor

@apgupta3303 apgupta3303 commented Mar 13, 2024

Fixing Decoding Times Error

⚙️ Release Notes

  • This PR changes the decoding schedule, so it only decodes the times field if it is present. This is necessary because times is not encoded if it was empty, so then it errors when trying to decode it if it was never encoded.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar self-assigned this Mar 13, 2024
@philippzagar philippzagar added the enhancement New feature or request label Mar 13, 2024
@philippzagar philippzagar self-requested a review March 13, 2024 01:06
Copy link
Member

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apgupta3303 for the PR, looks great!

Sources/SpeziMedication/Models/Schedule.swift Show resolved Hide resolved
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @apgupta3303! I restarted our runners; seems to have been an issue with Xcode 15.3 and the stability to startup the simulator.

The PR and the fix looks good to me 👍

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.79%. Comparing base (f5e284d) to head (e22a5bd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   52.04%   54.79%   +2.75%     
==========================================
  Files          21       21              
  Lines         982      982              
==========================================
+ Hits          511      538      +27     
+ Misses        471      444      -27     
Files Coverage Δ
Sources/SpeziMedication/Models/Schedule.swift 43.14% <100.00%> (+11.77%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e284d...e22a5bd. Read the comment docs.

@philippzagar
Copy link
Member

philippzagar commented Mar 13, 2024

@apgupta3303 Only SwiftLint errors are left (this includes the build errors), please fix them and then you can merge the PR. Thanks for the bugfix! 🚀

@PSchmiedmayer PSchmiedmayer merged commit 03d82c2 into StanfordSpezi:main Mar 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants