don't request tiles outside the total profile interval #40
Conversation
src/app.rs
Outdated
| @@ -1322,7 +1322,8 @@ impl Config { | |||
| } | |||
| } | |||
|
|
|||
| fn request_tiles(&mut self, request_interval: Interval) -> Vec<TileID> { | |||
| fn request_tiles(&mut self, cx: &mut Context) -> Vec<TileID> { | |||
| let request_interval = cx.view_interval.intersection(cx.total_interval); | |||
There was a problem hiding this comment.
I think we want self.interval not cx.total_interval (and therefore we do not need to pass cx at all).
There was a problem hiding this comment.
BTW the viewer still crashes if you scroll far enough so that all the data is outside the view interval. But that points towards being defensive on the other end.
There was a problem hiding this comment.
Yeah. We should probably harden the StateDataSource to avoid crashing when the interval is empty. There are (at least in principle) reasons why you might want to do this when viewing multiple profiles. (E.g., you could be off the end of one profile but not of another.)
There was a problem hiding this comment.
I can submit a PR to legion next week after this one is merged
This PR makes the view avoid requesting tiles outside the profile
total_interval, which can otherwise lead to crashes.fixes: #39
cc @elliottslaughter