[WIP] Plumbing for source locator #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
commented
Oct 20, 2023
bryevdv
commented
Oct 20, 2023
bryevdv
commented
Oct 20, 2023
bryevdv
commented
Oct 20, 2023
bryevdv
commented
Oct 20, 2023
bryevdv
commented
Oct 20, 2023
bryevdv
commented
Oct 20, 2023
bryevdv
commented
Oct 20, 2023
|
@elliottslaughter once you are happy with this I have the small backend change ready on a legion branch as well 
|
elliottslaughter
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
DataSourceDescriptionstruct with asource_locatorattribute that can be displayed as the app title when present. A corresponding PR will be needed in the frontend to actually compute a common prefix and add it toStateDataSource.The PR resulted from a good amount of just following the compiler and making things fit, but I have doubts about some of the changes, comments inline @elliottslaughter.