Add a FileDataSource that fetches archive files from local disk #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
reviewed
Oct 19, 2023
bryevdv
approved these changes
Oct 19, 2023
| ) -> SlotMetaTile { | ||
| let req = TileRequestRef { entry_id, tile_id }; | ||
| let mut path = self.basedir.join("slot_meta_tile"); | ||
| path.push(&req.to_slug()); |
There was a problem hiding this comment.
I think the mut could be ditched in these cases too, if desired
let path = self.basedir.join("slot_meta_tile").join(&req.to_slug());There was a problem hiding this comment.
Yeah. I didn't write this because I'm not 100% sure the Rust compiler can optimize away the extra allocation, but maybe writing this in a perfectly allocation-optimal way isn't actually necessary...
I'll plan to keep it for now, though maybe it's something one of us could look into.
There was a problem hiding this comment.
FWIW My personal going-in position would be to prioritize immutability in the code as much as possible, over perfectly minimal allocations, especially in a GUI that only needs to cater to (slow) human response times (until/unless a need for specific optimization is demonstrated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intended use case is to be able to "attach" to archives that happen to be located on a local disk, e.g.:
So you no longer have to host these over a webserver if you don't want to.