-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ESC to reset UI #29
Conversation
Most of this is fine, but:
To me it seems unintuitive that this would be controlled by ESC. It's a part of the control UI and not a pop-up window. And we don't touch any other part of the control panel (i.e., this does not implement a "reset to defaults" on the control panel). What do other people think? |
I could see it going either way, but this was the explicit request from @lightsighter when I asked about the requirements (via slack) |
@lightsighter can you clarify? I'm surprised that you want ESC to reset kind filters. |
I don't think I wanted it to reset the filters. I just wanted the pop-up box to go away. Although it might be nice if nothing is selected and you hit ESC then that clears the filters, but mainly what I want is for ESC to unselect anything I've selected and close any pop-up boxes. |
👍 my misunderstanding, I've reverted that part in a2a5129 and also cleared the merge conflict. |
Thanks for the clarification. I think it might be nice to have an option to reset things like filters, but I worry about having it be on ESC because it seems easy to press by accident. But we could potentially have a Anyway, this looks good to me now, so I'll take it once CI passes. Please keep sending these kinds of UI feedback items if there is other stuff that we should consider. |
This PR adds support for having the ESC key reset the UI. cc @lightsighter
Reset includes:
This PR also applies some clippy fixes related to
or_default
.cc @elliottslaughter if there is some better approach that does not requires passing the windows list through, please let me know.