review comments

src/app.rs

@@ -2543,7 +2543,7 @@ pub fn start(mut data_sources: Vec<Box<dyn DeferredDataSource>>) {
     env_logger::try_init().unwrap_or(()); // Log to stderr (if you run with `RUST_LOG=debug`).
 
     let app_name = if data_sources.len() == 1 {
-        match data_sources[0].get_description().source_locator {
+        match data_sources[0].fetch_description().source_locator {
             Some(source_locator) => source_locator,
             _ => String::from("Legion Prof"),
         }

src/deferred_data.rs

@@ -4,8 +4,7 @@ use crate::data::{
 };
 
 pub trait DeferredDataSource {
-    fn fetch_description(&mut self);
-    fn get_description(&mut self) -> DataSourceDescription;
+    fn fetch_description(&mut self) -> DataSourceDescription;
     fn fetch_info(&mut self);
     fn get_infos(&mut self) -> Vec<DataSourceInfo>;
     fn fetch_summary_tile(&mut self, entry_id: &EntryID, tile_id: TileID, full: bool);
@@ -37,9 +36,7 @@ impl<T: DataSourceMut> DeferredDataSourceWrapper<T> {
 }
 
 impl<T: DataSourceMut> DeferredDataSource for DeferredDataSourceWrapper<T> {
-    fn fetch_description(&mut self) {}
-
-    fn get_description(&mut self) -> DataSourceDescription {
+    fn fetch_description(&mut self) -> DataSourceDescription {
         self.data_source.fetch_description()
     }
 
@@ -111,17 +108,10 @@ impl<T: DeferredDataSource> CountingDeferredDataSource<T> {
 }
 
 impl<T: DeferredDataSource> DeferredDataSource for CountingDeferredDataSource<T> {
-    fn fetch_description(&mut self) {
-        self.start_request();
+    fn fetch_description(&mut self) -> DataSourceDescription {
         self.data_source.fetch_description()
     }
 
-    fn get_description(&mut self) -> DataSourceDescription {
-        let result = self.data_source.get_description();
-        self.outstanding_requests -= 1;
-        result
-    }
-
     fn fetch_info(&mut self) {
         self.start_request();
         self.data_source.fetch_info()
@@ -165,14 +155,10 @@ impl<T: DeferredDataSource> DeferredDataSource for CountingDeferredDataSource<T>
 }
 
 impl DeferredDataSource for Box<dyn DeferredDataSource> {
-    fn fetch_description(&mut self) {
+    fn fetch_description(&mut self) -> DataSourceDescription {
         self.as_mut().fetch_description()
     }
 
-    fn get_description(&mut self) -> DataSourceDescription {
-        self.as_mut().get_description()
-    }
-
     fn fetch_info(&mut self) {
         self.as_mut().fetch_info()
     }

src/file_data.rs

@@ -33,7 +33,7 @@ impl FileDataSource {
 impl DataSource for FileDataSource {
     fn fetch_description(&self) -> DataSourceDescription {
         DataSourceDescription {
-            source_locator: None,
+            source_locator: Some(String::from(self.basedir.to_string_lossy())),
         }
     }
     fn fetch_info(&self) -> DataSourceInfo {

src/http/client.rs

@@ -64,11 +64,9 @@ impl HTTPClientDataSource {
 }
 
 impl DeferredDataSource for HTTPClientDataSource {
-    fn fetch_description(&mut self) {}
-
-    fn get_description(&mut self) -> DataSourceDescription {
+    fn fetch_description(&mut self) -> DataSourceDescription {
         DataSourceDescription {
-            source_locator: None,
+            source_locator: Some(self.baseurl.to_string()),
         }
     }
 

src/parallel_data.rs

@@ -27,9 +27,7 @@ impl<T: DataSource + Send + Sync + 'static> ParallelDeferredDataSource<T> {
 }
 
 impl<T: DataSource + Send + Sync + 'static> DeferredDataSource for ParallelDeferredDataSource<T> {
-    fn fetch_description(&mut self) {}
-
-    fn get_description(&mut self) -> DataSourceDescription {
+    fn fetch_description(&mut self) -> DataSourceDescription {
         self.data_source.fetch_description()
     }