Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legion_prof improvements #1551

Open
syamajala opened this issue Sep 12, 2023 · 4 comments
Open

legion_prof improvements #1551

syamajala opened this issue Sep 12, 2023 · 4 comments

Comments

@syamajala
Copy link
Contributor

Here are some improvements that would be nice to have for the new legion_prof:

  1. Color instances using a heat map based on size so we can easily tell which ones are large and small. From my understanding the coloring is currently random. Ideally they would also be sorted by size vertically as well, but I guess thats not possible unless they are created at the same nanosecond
  2. Web viewer needs error messages when it cant load a profile, either invalid url or bad permissions
  3. Fix permissions for profiles generated on Perlmutter. I guess they are not world readable by default, which is very annoying.
  4. Mode for dumping profile to SQLite so you can write scrape profiles, write post processing scripts, generate additional plots.
@syamajala syamajala added the S3D label Sep 12, 2023
@syamajala
Copy link
Contributor Author

It would be nice if https://legion.stanford.edu/prof-viewer/ was a landing page where you could type in the url to the profile you want to load.

@syamajala
Copy link
Contributor Author

It would be nice if you could just export plots as PNG from legion_prof. Maybe like how plotly has a little camera in the top right corner of every plot.

manopapad added a commit to manopapad/prof-viewer that referenced this issue Sep 27, 2023
Included some of my own wishlist items, plus items from StanfordLegion/legion#1551 and StanfordLegion#25
@suranap
Copy link

suranap commented Nov 13, 2023

I'll add some ideas here.

  1. Some kind of title and/or memo field so people know what this profile is about.
  2. A one-line summary of the hardware config: e.g. 8 nodes, 4 GPUs each, etc.
  3. Some aggregation/query features. e.g. what's the average time spent in task A during this window of time.
  4. A way to output structured log files (e.g. json) so users can convert to alternate log analysis tools if needed.

@lightsighter
Copy link
Contributor

I think (1) was already handled: StanfordLegion/prof-viewer#28

In general, I think we should start to move feature requests like this over to profiler repo (at least the visualization based ones, the ones requesting other output formats can stay here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants