Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repoint branches #1962

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Repoint branches #1962

merged 2 commits into from
Dec 4, 2024

Conversation

mcoduoza
Copy link
Collaborator

@mcoduoza mcoduoza commented Dec 4, 2024

No description provided.

@mcoduoza mcoduoza merged commit 2cc8a58 into master Dec 4, 2024
2 of 3 checks passed
mcoduoza added a commit that referenced this pull request Dec 5, 2024
This reverts commit 2cc8a58, reversing
changes made to 89f0461.
@mcoduoza mcoduoza requested a review from steveri December 5, 2024 02:19
@mcoduoza
Copy link
Collaborator Author

mcoduoza commented Dec 5, 2024

Hi @steveri, could you please look into this failure? https://buildkite.com/stanford-aha/aha-flow/builds/10889

This seems to have passed all the checks on garnet.
Thanks

@steveri
Copy link
Contributor

steveri commented Dec 5, 2024

?? You merged this? Did the problem get fixed? I think I know how to remove the error, even though it apparently was not complaining earlier...?

@steveri
Copy link
Contributor

steveri commented Dec 5, 2024

I am attempting to repeat the earlier failure here:
https://buildkite.com/stanford-aha/aha-flow/builds/10893
...this should fail, same as your build 10889

I started a new build with a potential hotfix, it should run here when/if it gets a free agent
https://buildkite.com/stanford-aha/aha-flow/builds/10894

@steveri
Copy link
Contributor

steveri commented Dec 5, 2024

Looks like a VCS versioning problem. Below, two buildkite runs, each using the same garnet repo version, one fails and one succeeds:

https://buildkite.com/stanford-aha/aha-flow/builds/10889
FAILS using aha df2e802, garnet 4479910f, vcs T-2022.06
"Error-[XMREMX] Cross-module reference resolution error"
Chronologic VCS (TM)
Version T-2022.06-SP2_Full64 -- Thu Dec 5 14:00:19 2024

https://buildkite.com/stanford-aha/garnet/builds/5369
SUCCEEDS using garnet 4479910f, vcs Q-2020.033
Chronologic VCS (TM)
Version Q-2020.03-SP2_Full64 -- Wed Dec 4 16:12:38 2024

@mcoduoza
Copy link
Collaborator Author

mcoduoza commented Dec 5, 2024

I merged it then reverted when I realized it failed. Hmm, so the garnet CI is using a different VCS version than aha?

@steveri
Copy link
Contributor

steveri commented Dec 5, 2024

I merged it then reverted when I realized it failed. Hmm, so the garnet CI is using a different VCS version than aha?

Looks like that may be the case. I am continuing my investigation, I should be able to come up with code that works with both versions of vcs I think.

@steveri
Copy link
Contributor

steveri commented Dec 6, 2024

I have code that works with

  • vcs version Q-2020 running on either ubuntu or centos
  • vcs version T-2022 running on centos but BREAKS if run on ubuntu

I am hoping to get this resolved by tomorrow sometime... :(

@mcoduoza
Copy link
Collaborator Author

mcoduoza commented Dec 6, 2024

oh wow :( ok thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants