Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libboost #1947

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Remove libboost #1947

merged 2 commits into from
Jul 31, 2024

Conversation

bobcheng15
Copy link
Collaborator

  1. Remove libbost from the list of packages installed in the Dockerfile
  2. Updated Lego so now it no longer depends on libboost

@bobcheng15 bobcheng15 self-assigned this Jul 30, 2024
@bobcheng15
Copy link
Collaborator Author

@steveri, Gautham reworked the source code of Lego, so it no longer depends on libboost. Therefore, I have removed the installation of libboost from the Dockerfile. Hopefully this addresses the image size issue I introduced in my last PR merge.

@steveri
Copy link
Contributor

steveri commented Jul 30, 2024

Thanks guys!

But oops it looks like all three regression tests failed?
https://buildkite.com/stanford-aha/aha-flow/builds/10704

I will restart them to see if maybe it was a transient error...new attempt is in progress here:
https://buildkite.com/stanford-aha/aha-flow/builds/10705

@bobcheng15
Copy link
Collaborator Author

@steveri sounds good, thanks for catching the regression failure!

@steveri
Copy link
Contributor

steveri commented Jul 30, 2024

The other good news is (assuming we eventually get the CI to pass), it looks as though the docker image size is down to less than 6GB:

% docker images
REPOSITORY               TAG               IMAGE ID       CREATED             SIZE
stanfordaha/garnet       remove_libboost   4683f44eb0a1   About an hour ago   5.67GB
stanfordaha/garnet       latest            64581a7cbc7c   8 hours ago         6.98GB
stanfordaha/garnet       <none>            9bba7e64a05a   42 hours ago        8.14GB
stanfordaha/garnet       <none>            a8ccf33f2faf   2 days ago          8.14GB
stanfordaha/garnet       <none>            2365f0e0ebcf   6 weeks ago         7.41GB

@steveri
Copy link
Contributor

steveri commented Jul 31, 2024

All checks passed.
LGTM.
Thanks very much!

@bobcheng15 bobcheng15 merged commit 95c843f into master Jul 31, 2024
3 checks passed
@bobcheng15 bobcheng15 deleted the remove_libboost branch July 31, 2024 17:09
@bobcheng15 bobcheng15 restored the remove_libboost branch July 31, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants