-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node 20 #186
base: master
Are you sure you want to change the base?
Upgrade node 20 #186
Conversation
…suming someone has access to the hubot-botframework repo
This reverts commit 31eafac.
@rebrowning I've managed to fix some of the build errors in my PR #188, so you should find that once I have that merged if you merge from master it should fix the issues you were seeing on build. That PR also removes bionic and el7 which we don't need for the next release. |
@rebrowning Hi, I'm not sure if you are able to help. But we're trying to get st2chatops to run with node20 now that we have got rid of the older OS vefrsions, and fixed some issues that were failing st2chatops build. |
@amanda11 Not sure what the failure is, but if you're getting an npm login error when I was running this locally I had to remove the |
pin coffeescript which will allow builds with node 20 to succeed. No other libraries needed to be updated (excluding and assuming no issues with hubot-botframework if someone has access to it)
locally I have to remove
hubot-botframework
, hopefully someone in the community has access to that repo, but the current most recent (6 years+) npm version does not work, and the repo has some restrictions that prevents me from pulling anything from the repo. I can't even clone it to test a local file module.I also upgraded the node version in focal and rocky, using nvm to do the install. The two older versions do not have a compiler that can install node 20, I'm not sure what we want to do about that but a few attempts at doing it cleanly were unsuccessful, I'm not sure if supporting them warrants doing a sketchy secondary install of a compiler to try and make it work.
open to any feedback of what else needs to be updated to try and move this forwards.