Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pants: Add BUILD metadata for integration tests #6275

Merged
merged 9 commits into from
Nov 16, 2024

Conversation

cognifloyd
Copy link
Member

This PR's commits were extracted from #6273 where I'm working on getting pants+pytest to run integration tests.

This PR primarily makes this change, plus a few other minor things:

  • BUILD metadata for integration tests, including explicit dependencies that could not be inferred and uses= config for our pants-plugins/uses_services plugin.

The other minor things I included are:

  • Silence pants' remote cache warnings. GitHub Actions Caching has a really low API rate limit that we hit regularly. When we hit that, we get 429 errors that pants displays as warnings (LOTS of warnings). The warnings are not actionable--we can't do anything about GitHub's paltry rate limit--and there is basically no impact on our CI--pants just runs the process if it can't find it in the cache or the cache returns an error. All of those warnings were obscuring the actual test output, so this silences them.
  • I couldn't run some tests locally because they require passwordless sudo, which I don't want to configure. So, I skipped those tests, leaving them to run only in CI.
  • Add a generous timeout for pants to run each test file. I set [test].timeout_default=600 (ie 10min in seconds) so that pants doesn't hang running integration tests if something goes wrong. If a test times out, pants will just retry it up to 3 times, so this just serves to speed up CI when we run into edge cases.

@cognifloyd cognifloyd added this to the pants milestone Nov 12, 2024
@cognifloyd cognifloyd self-assigned this Nov 12, 2024
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Nov 12, 2024
Copy link
Contributor

@winem winem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I really appreciate that the cache failures aren't shown anymore and that passwordless sudo is no longer required when running the tests locally!

@cognifloyd cognifloyd merged commit e51fe93 into master Nov 16, 2024
42 checks passed
@cognifloyd cognifloyd deleted the pants-itests-build-metadata branch November 16, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pantsbuild size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants