Use plain asserts and pytest-mock in tests/unit/test_backend.py
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parametrization is incompatible with unittest-style tests. So, this migrates test_backend to use plain asserts instead.
cognifloyd
changed the title
tests/unit/test_backend.pytests/unit/test_backend.py
cognifloyd
force-pushed
the
pytest-conversion
branch
3 times, most recently
from
988f1ce
to
958e162
Compare
Parametrization also doesn't play nicely with @mock.patch.object decorators, so this refactor paves the way for additional parametrization in future PRs.
cognifloyd
force-pushed
the
pytest-conversion
branch
from
958e162
to
f65cf63
Compare
nzlosh
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #115, I need to add tests, and the cleanest way to do that is with parametrization. But:
@mock.patch.objectdecorators.So, this switches:
unittest.TestCasewith unittest asserts, to simple test functions with plain asserts.mocktopytest-mock(a nice wrapper aroundunittest.mockfor pytest-style fixtures)This PR only refactors
tests/unit/test_backend.py, not any of the other test files.(Contributions welcome to migrate the other tests.)
In order to review this PR, please review each commit separately. For the first commit make sure to "hide whitespace":
(see https://github.blog/news-insights/product-news/ignore-white-space-in-code-review/ for instructions on hiding whitespace changes).