REFACTOR: Move intelligence from helpers.js to Go code #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Records such as A, CNAME, and so on are entirely processed in helpers.js. This makes it difficult to do unit testing, or process more complex record types such as LOC.
Resolution:
With this PR, we begin migrating the intelligence from helpers.js to the Go code. Instead of fully processing record data in helpers.js, we blindly pass the parameters are raw data. The Go code then converts these "raw" records to normal RecordConfigs.
A downside is that a lot of the Go code is repetitive. However, we will eventually automatically generate this code. Hopefully that will make that code generated automatically.