TESTING: parse_tests files should be uniformly formatted and sorted #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The format of files in pkg/js/parse_tests are inconsistent, which makes refactoring difficult.
A future refactoring will cause these tests to fail because the .Records lists will be in a different (but equivalent) order. Currently the data is in the same order as the records are input. In the future, the ordering will be different. The order of .Records doesn't matter, thus this test data is brittle.
Solutions:
.jsfiles are passed throughdnscontrol fmt -i x -o x.jsonfiles are passed through fmtjson.Recordsin.jsonfiles are now PrettySort'ed, so that the order is predictable.