Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIND: Allow use in cmode=concurrent #3254

Merged
merged 5 commits into from
Dec 17, 2024
Merged

BIND: Allow use in cmode=concurrent #3254

merged 5 commits into from
Dec 17, 2024

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Dec 16, 2024 •
edited
Loading

Fixes #3252

  • BIND: Enable cmode=concurrent
  • BIND: Calculate the zone's filename any time it is needed rather than trying to store it for later use.
    • bindProvider.zoneFileFound: Remove. This is written to but never read.
    • bindProvider.zonefile: Remove. This is cached but always regenerated. Cache wasn't threadsafe.
  • BIND: Implement ZoneCreator so that when BIND is your registrar (which it shouldn't be), at least you get reasonable messages.
  • BIND: Improve messages around ensuring zones exist

@tlimoncelli tlimoncelli reopened this Dec 16, 2024
@tlimoncelli tlimoncelli mentioned this pull request Dec 16, 2024
Closed
@tlimoncelli tlimoncelli changed the title BIND: Remove unneeded state (BIND.zoneFileFound) BIND: BUG: BIND may write to incorrect zonefile name Dec 16, 2024
github-actions[bot]
github-actions bot previously requested changes Dec 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes detected by Check Git Status Action

@tlimoncelli tlimoncelli changed the title BIND: BUG: BIND may write to incorrect zonefile name BIND: All use in cmode=concurrent and fix related bugs Dec 16, 2024
@tlimoncelli tlimoncelli changed the title BIND: All use in cmode=concurrent and fix related bugs BIND: Allow use in cmode=concurrent Dec 16, 2024
@tlimoncelli tlimoncelli merged commit a7e83de into main Dec 17, 2024
19 checks passed
@tlimoncelli tlimoncelli deleted the tlim_3252_bindfile branch December 17, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
provider-BIND
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BIND does not create zonefile anymore
2 participants
@tlimoncelli @cafferata