FEATURE: enable --report for preview (not just push) #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hmoffatt Please test. |
|
@cafferata Please review the docs and verify the hyperlink works. |
cafferata
reviewed
Oct 9, 2024
cafferata
reviewed
Oct 9, 2024
cafferata
reviewed
Oct 9, 2024
documentation/json-reports.md
Outdated
|
|
||
| To enable the report option you must use the `push` operation in combination with the `--report <filename>` option. This generates the json file. | ||
| To generate the report, add the `--report <filename>` option to a preview or | ||
| push command (this includes `preview`, `ppreview`, `oldpreview`, `push`, |
There was a problem hiding this comment.
At the time of writing there is (still) no oldpreview and oldpush.
There was a problem hiding this comment.
I'm willing to live with that.
There was a problem hiding this comment.
See also my comment #3142 (comment)
Co-authored-by: Jeffrey Cafferata <[email protected]>
Co-authored-by: Jeffrey Cafferata <[email protected]>
|
Looks good @tlimoncelli, thanks. |
|
@cafferata I removed the reference to old* commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3148