Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easier way to create custom record types: "Rdata style" #3082

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add easier way to create custom record types: "Rdata style" #3082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
759ba0b
wip!
tlimoncelli Aug 14, 2024
292198a
wip!
tlimoncelli Aug 14, 2024
67a93e8
wip!
tlimoncelli Aug 14, 2024
13e1b8a
wip!
tlimoncelli Aug 14, 2024
149ba6b
tests work
tlimoncelli Aug 14, 2024
ce2cca4
unexport MakePageRule
tlimoncelli Aug 14, 2024
70e95c7
wip!
tlimoncelli Aug 14, 2024
c87735c
rename
tlimoncelli Aug 15, 2024
d038724
fixup!
tlimoncelli Aug 15, 2024
5e1419f
renames
tlimoncelli Aug 16, 2024
54e3676
wip!
tlimoncelli Aug 16, 2024
cf2f0f2
fixup!
tlimoncelli Aug 16, 2024
226c951
Fix TOC
tlimoncelli Aug 19, 2024
dace25d
fix SUMMARY
tlimoncelli Aug 19, 2024
a352efa
Merge branch 'main' into tlim_rdata
tlimoncelli Aug 20, 2024
c1e3e40
Merge branch 'main' into tlim_rdata
tlimoncelli Aug 21, 2024
fd35bf3
Merge branch 'main' into tlim_rdata
tlimoncelli Sep 18, 2024
84f8e48
empty
tlimoncelli Dec 18, 2024
1a3368d
Merge branch 'main' into tlim_rdata
tlimoncelli Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions commands/printIR.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"github.com/StackExchange/dnscontrol/v4/pkg/js"
"github.com/StackExchange/dnscontrol/v4/pkg/normalize"
"github.com/StackExchange/dnscontrol/v4/pkg/rfc4183"
"github.com/StackExchange/dnscontrol/v4/pkg/rtypes"
"github.com/urfave/cli/v2"
)

Expand Down Expand Up @@ -130,7 +129,7 @@ func ExecuteDSL(args ExecuteDSLArgs) (*models.DNSConfig, error) {
return nil, fmt.Errorf("executing %s: %w", args.JSFile, err)
}

err = rtypes.PostProcess(dnsConfig.Domains)
err = models.ConvertRawRecords(dnsConfig.Domains)
if err != nil {
return nil, err
}
Expand Down
3 changes: 2 additions & 1 deletion documentation/SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@
* [Documentation Style Guide](styleguide-doc.md)
* [DNSControl is an opinionated system](opinions.md)
* [Writing new DNS providers](writing-providers.md)
* [Creating new DNS Resource Types (rtypes)](adding-new-rtypes.md)
* [Creating new DNS Resource Types (Rdata-style)](adding-new-rtypes-rdata.md)
* [Creating new DNS Resource Types (RC-Style)](adding-new-rtypes.md)
* [Integration Tests](integration-tests.md)
* [Unit Testing DNS Data](unittests.md)
* [Bug Triage Process](bug-triage.md)
Expand Down
Loading
Loading