Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat TXT records as one long string #2598

Closed
wants to merge 60 commits into from
Closed

Treat TXT records as one long string #2598

wants to merge 60 commits into from

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Oct 18, 2023

TXT record handling is complex because we abstract them at the wrong layer.

OLD: We try to maintain TXT records as a list of sub-strings, creating complexity at the main level, the diff engine, and the provider level.

NEW: TXT records are stored as a single (possibly very long) string. If a provider's API requires long strings to be split up, the provider must handle that internally. Thus, the sub-strings are invisible to DNSControl's main functions and the difference engine.

This is a major rewrite and will require extensive testing by the providers. We'll do a pre-release to make it easier to test.

@tlimoncelli tlimoncelli marked this pull request as draft October 18, 2023 14:55
@tlimoncelli tlimoncelli reopened this Nov 1, 2023
@tlimoncelli tlimoncelli changed the title Process TXT records in a more reliable and consistent manner Treat TXT records as one long string Nov 1, 2023
@tlimoncelli tlimoncelli deleted the tlim_newtxt branch November 29, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant