Fix the return types of *_BUILDER functions
#2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They actually return `DomainModifier`, not `RecordModifier`. This allows you to use them as arguments in `D` without type-checking reporting an error (because it's not an error, it's correct).
|
Thanks for noticing and fixing this! |
cafferata
added a commit
to cafferata/dnscontrol
that referenced
this pull request
Oct 9, 2023
cafferata
added a commit
to cafferata/dnscontrol
that referenced
this pull request
Jan 11, 2024
cafferata
added a commit
to cafferata/dnscontrol
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They actually return
DomainModifier, notRecordModifier. This allows you to use them as arguments inDwithout type-checking reporting an error (because it's not an error, it's correct).Fixes #2582.
Possibly related note: I noticed the SPF_BUILDER documentation page is broken. It doesn't display any content, and appears in the wrong section ("Record Modifiers" instead of "Domain Modifiers"), so it seems like the documentation is broken and hasn't updated the moving of the file properly, which is what I've done here but for more things, so they might break too...
I'm not sure how to fix that though, but it's probably a separate issue anyway, but still related so I'm noting it here before it breaks more things. I don't actually have much experience with much of this (I've never used Go or TypeScript before, and rarely use JavaScript), so I'm not 100% sure what I'm doing... but I think I did this properly, it's fixed in my testing.
Thank you. :)