Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INWX: Support up to 2,147,483,647 domains (old limit was 20) #2566

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

patschi
Copy link
Contributor

@patschi patschi commented Sep 23, 2023

I'd propose this simple "fix" (I guess rather workaround?) to use more than 20 domains on INWX. I have verified it working.

Without this line:

******************** Domain: dnscontrol20.com
3 corrections (INWX)
#1: + CREATE A dnscontrol20.com 1.1.1.1 ttl=300
#2: ± MODIFY NS dnscontrol20.com: (ns.ote.inwx.de. ttl=86400) -> (ns.ote.inwx.de. ttl=300)
#3: ± MODIFY NS dnscontrol20.com: (ns2.ote.inwx.de. ttl=86400) -> (ns2.ote.inwx.de. ttl=300)
******************** Domain: dnscontrol30.com
WARNING: Zone 'dnscontrol30.com' does not exist in the 'INWX' profile and will be added automatically.
WARNING: No nameservers declared; skipping registrar. Add {no_ns:'true'} to force.
Done. 3 corrections.

When applying:

******************** Domain: dnscontrol20.com
3 corrections (INWX)
#1: + CREATE A dnscontrol20.com 1.1.1.1 ttl=300
#2: ± MODIFY NS dnscontrol20.com: (ns.ote.inwx.de. ttl=86400) -> (ns.ote.inwx.de. ttl=300)
#3: ± MODIFY NS dnscontrol20.com: (ns2.ote.inwx.de. ttl=86400) -> (ns2.ote.inwx.de. ttl=300)
******************** Domain: dnscontrol30.com
3 corrections (INWX)
#1: + CREATE A dnscontrol30.com 1.1.1.1 ttl=300
#2: ± MODIFY NS dnscontrol30.com: (ns.ote.inwx.de. ttl=86400) -> (ns.ote.inwx.de. ttl=300)
#3: ± MODIFY NS dnscontrol30.com: (ns2.ote.inwx.de. ttl=86400) -> (ns2.ote.inwx.de. ttl=300)
Done. 6 corrections.

All values larger than 2147483647 will exceed int type defined in goinwx go library and will fail. I'd think the chance of having more than two billion domains is very unlikely and is the simplest fix avoiding to implement entire paging system.

This fixes #2512

@tlimoncelli tlimoncelli changed the title inwx: workaround allowing use of >20 domains INWX Enable use of >20 domains Sep 27, 2023
@tlimoncelli
Copy link
Contributor

I love this kind of fix. I don't understand why providers think small page sizes are fine.

@tlimoncelli tlimoncelli changed the title INWX Enable use of >20 domains INWX: Support up to 2,147,483,647 domains (old limit was 20) Sep 27, 2023
@tlimoncelli tlimoncelli merged commit 4e3f5f3 into StackExchange:master Sep 27, 2023
@patschi patschi deleted the inwx-20domains branch October 2, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INWX: Does not work with more than 20 Domains
2 participants