Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(spot illustrations): update spot prototype usage instructions #1837

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

KyleMit
Copy link
Collaborator

@KyleMit KyleMit commented Oct 11, 2024

Follow up to #1116, particularly @b-kelly "technically" comment

Using the Prototype syntax, Spot data attributes now need to be prefixed with "Spot":

- <svg data-spot="Wave"></svg>
+ <svg data-spot="SpotWave"></svg>

Copy link
Collaborator

@b-kelly b-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for following up on this!

@giamir giamir merged commit d80d2e1 into develop Oct 14, 2024
7 of 11 checks passed
@giamir giamir deleted the kylemit/spot-illustrations branch October 14, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants