Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased specificity to get a higher priority for rewriting styles from primary.css #1134

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ondrejkonec
Copy link

@ondrejkonec ondrejkonec commented Oct 5, 2022

Hi!

I took care about this bug #957

Variants does not work without s-post-summary selector, so it is possible to increase the specificity of the selector with certainty and achieve that it will have a higher priority and override s-post-summary__watched if both selectors are there. We can remove this selector override when it's not in primary.css file.

Tested in Stacks and https://stackoverflow.com/

Shot from Stackoverflow.com

I have one question about that. What is primary.css used for or why are the same elements there?

Hope this helps!

@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit a74361e
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/633d26454fc2d000070a08fe
😎 Deploy Preview https://deploy-preview-1134--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant