Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet framework #312

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Update dotnet framework #312

merged 9 commits into from
Jun 10, 2024

Conversation

b-kelly
Copy link
Collaborator

@b-kelly b-kelly commented Jun 10, 2024

This PR updates the dotnet target framework from netstandard2.0 to net8.0 (the latest LTS). Despite there being no breaking changes in the code itself, I think that updating the framework target is a breaking-ish change, so I also bumped the version from 6.0.2 to 7.0.0.

The reasons for updating the framework are as follows:

  1. We needed to drop the Microsoft.AspNetCore.Html.Abstractions standalone package
    • the standalone packages are deprecated and are now shipped in the framework reference (further reading)
  2. There are no longer any new versions of netstandard being shipped since there is now one unified framework (further reading)

@b-kelly b-kelly added dependencies Pull requests that update a dependency file BREAKING CHANGE Includes a change to the public api that is not backwards compatible labels Jun 10, 2024
@b-kelly b-kelly requested a review from a team June 10, 2024 15:22
Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @b-kelly.

I opened a very similar PR here on Friday that I then ended up closing since the pipeline issue turned out to be a different reason.

I think we might want to target 2 frameworks since in Core we are not yet on dotnet 8.
In Stacks.Razor we are doing the same (support both 6 and 8 - Samo helped with that a while back and I did the same for the PR I ended up closing).

Thank you

@b-kelly
Copy link
Collaborator Author

b-kelly commented Jun 10, 2024

@giamir Good callout. I'll review the PR you had closed to ensure that we're properly supporting net6.0 as well (for now, it's EOL soon and I know folks are working on the migration as we speak).

@giamir
Copy link
Contributor

giamir commented Jun 10, 2024

@giamir Good callout. I'll review the PR you had closed to ensure that we're properly supporting net6.0 as well (for now, it's EOL soon and I know folks are working on the migration as we speak).

If we can target both frameworks without big headaches I would just do it to avoid having to coordinate. We can drop support for 6 later on. 🙂

@b-kelly
Copy link
Collaborator Author

b-kelly commented Jun 10, 2024

@giamir Updating to target both was trivial. Ready for review!

@b-kelly b-kelly requested a review from giamir June 10, 2024 17:18
@b-kelly b-kelly merged commit 350f251 into production Jun 10, 2024
3 checks passed
@b-kelly b-kelly deleted the bkelly/update-frameworks branch June 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Includes a change to the public api that is not backwards compatible dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants