Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OBJECT FREQ #2105

Merged
merged 6 commits into from
Apr 19, 2022
Merged

Support OBJECT FREQ #2105

merged 6 commits into from
Apr 19, 2022

Conversation

Avital-Fine
Copy link
Contributor

@slorello89 slorello89 mentioned this pull request Apr 19, 2022
Open
@NickCraver
Merge remote-tracking branch 'origin/main' into pr/2105
6211f49
@NickCraver
Fix comment merge
3492c6e
@NickCraver
Fix tests
6a323ad 
We can't be changing configs in the middle of a test, this is hostile to other tests running on the same server (e.g. this will cause KeyTouch to fail). Instead, cope with either config - not worth setting up another test instance for, IMO.
NickCraver
NickCraver approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current looking good - will get merged in, thanks!

@NickCraver NickCraver merged commit f0fa79c into StackExchange:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
⚙️ area:API ⚙️ area:commands ➕ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avital-Fine @NickCraver