Support SINTERCARD #2078
Merged
Support SINTERCARD #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2022 14:39
NickCraver
reviewed
Apr 11, 2022
NickCraver
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Looking good I think, but I touched this so should get other eyes /cc @slorello89
slorello89
reviewed
Apr 11, 2022
There was a problem hiding this comment.
LGTM 👍, @NickCraver do you want to merge this into main? or do you want to work off a separate RC for Redis 7?
|
@slorello89 I see no advantage to waiting - if we're good we're good, let's get things in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis-stack.io/commands/sintercard/
#2055