Support LMOVE #2065
Merged
Support LMOVE #2065
+153
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nick Craver <[email protected]>
Co-authored-by: Nick Craver <[email protected]>
NickCraver
reviewed
Apr 4, 2022
|
@Avital-Fine for tests, check out the format |
Co-authored-by: Nick Craver <[email protected]>
Thank you! hope the merge won't be too bad 😅 |
NickCraver
requested changes
Apr 8, 2022
| @@ -1009,6 +1009,18 @@ public Task<long> ListLengthAsync(RedisKey key, CommandFlags flags = CommandFlag | |||
| return ExecuteAsync(msg, ResultProcessor.Int64); | |||
| } | |||
|
|
|||
| public RedisValue ListMove(RedisKey sourceKey, RedisKey destinationKey, ListSide whereFrom, ListSide whereTo, CommandFlags flags = CommandFlags.None) | |||
| { | |||
| var msg = Message.Create(Database, flags, RedisCommand.LMOVE, sourceKey, destinationKey, whereFrom == ListSide.Left ? "Left" : "right", whereTo == ListSide.Left ? "Left" : "right"); | |||
There was a problem hiding this comment.
We should be consistent in Left vs right here :)
| @@ -298,7 +298,7 @@ public async Task ListRightPushAsyncMultipleToExisitingKey() | |||
| { | |||
| Skip.IfMissingFeature(conn, nameof(RedisFeatures.PushMultiple), f => f.PushMultiple); | |||
| var db = conn.GetDatabase(); | |||
| RedisKey key = "testlist"; | |||
| RedisKey key = Me(); | |||
There was a problem hiding this comment.
Thanks for these fixes btw!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/commands/lmove/