Get LoRA script to work for single gpus #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added an additional boolean parameter to the script that represents whether to use a single gpu or not. |
asutermo
reviewed
Feb 16, 2024
train/base.py
Outdated
| def save_checkpoints(self, models: Models, optimizers: Optimizers, suffix=None): | ||
| barrier() | ||
| def save_checkpoints(self, models: Models, optimizers: Optimizers, suffix=None, single_gpu=False): | ||
| if single_gpu: |
There was a problem hiding this comment.
shouldn't this be 'if not single_gpu:'?
There was a problem hiding this comment.
I think that's fixed in this commit.
c00a449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request in 7 yrs or something so apologies in advance if I do anything wrong.
Currently, train_c_lora.py does not support training with single GPUs as doing so will fail with missing environment variables or calls to
torch.distributed.barrier()which (I think) is supposed to only work in multi-gpu environments.(e.g.) #28 #17
This pull request will will make some modifications to add single gpu support.