Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds sistr 1.1.2 #1049

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

adds sistr 1.1.2 #1049

wants to merge 3 commits into from

Conversation

Kincekara
Copy link
Collaborator

Closes #1001
I dare to update this tool and I regret it.
pip installation fails because of legacy libraries. mamba image became too big. So, I ended up using setup.py.
I added a readme file and a test. It looks like it is working but it may be good to test it further.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj
Copy link
Collaborator

I dare to update this tool and I regret it.
pip installation fails because of legacy libraries. mamba image became too big. So, I ended up using setup.py.

We thank you for your efforts 👏

It looks like there are some built-in tests that test a few different components. Could you try adding these test commands somewhere in the test stage and see what happens? see here: https://github.com/phac-nml/sistr_cmd?tab=readme-ov-file#development

@Kincekara
Copy link
Collaborator Author

@kapsakcj I tried to run internal tests via pytest but got errors mostly related to files. I am not sure that those tests are completed or compatible with this version. Instead, I added the test fasta as another test.
By the way, version 1.1.3 is coming. We can wait a little more...

@kapsakcj
Copy link
Collaborator

Darn OK. Thanks for trying anyways. Glad you added the additional test and thanks for making my requested changes.

I'm fine if you want to wait for v1.1.3, whatever you think is best. I don't think the changes between 1.1.2 and 1.1.3 look too drastic, but may be important for anyone working on serovars that are going to be updated in 1.1.3: https://github.com/phac-nml/sistr_cmd/blob/v1.1.3/CHANGELOG.md

@Kincekara
Copy link
Collaborator Author

There is something sketchy in the results. I am leaving this as a draft for now. I will do some more tests when I have time. In the meantime, if it is updated I'll change the version too.

@Kincekara Kincekara marked this pull request as ready for review November 20, 2024 15:01
@Kincekara
Copy link
Collaborator Author

I realized the previous image base is xenial. When I used focal instead of jammy, all pip problems were resolved. This way looks cleaner, so I decided to stick focal for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request An Update]: sistr
2 participants