Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Fedora packaging #7

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

LecrisUT
Copy link
Contributor

Now to handle the dependencies themselves an prepare for packaging

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 28, 2024

I've started with argon2 as a template on how to resolve the dependencies. Packit does not have proper dependencies support, but restarting the build should pick up the latest version

Also note the comments in commit 540aba2

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 2 times, most recently from 2ed6907 to bcf3cd5 Compare March 28, 2024 13:38
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 28, 2024

Here is my workflow for adding these:

$ export rust_pkg=...
$ mkdir ../rust-${rust_pkg} && cd ../rust-${rust_pkg} && touch rust2rpm.toml && rust2rpm ${rust_pkg}

After which I check https://bugzilla.redhat.com/ for any open review requests and https://crates.io/ for some other links.

  • If the package has a review request, add a link, remove the rust2rpm.toml, and copy the spec file from the link
  • If the package is already in fedora, copy the spec file and rust2rpm.toml (update the .conf file if necessary) and rerun rust2rpm ${rust_pkg}
  • If none of the above are the case, proceed with the files generated

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 2 times, most recently from f2d0bae to e19d3c1 Compare March 28, 2024 15:03
@LecrisUT LecrisUT marked this pull request as ready for review March 28, 2024 15:56
@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 6 times, most recently from acef2e6 to f824b03 Compare March 28, 2024 20:13
@LecrisUT LecrisUT marked this pull request as draft March 28, 2024 20:29
@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 4 times, most recently from e3d42de to 58d7fa1 Compare March 29, 2024 20:28
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Apr 25, 2024

/packit build

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Apr 25, 2024

Downstream has made quite some progress, the main blocker was sqlx which has quite a lot of dependencies, and now there only futures-intrusive is blocking. The main dependencies we need to work on fixing are:

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 2 times, most recently from 5bdd6b3 to 2c8f77a Compare April 26, 2024 08:41
@SriRamanujam
Copy link
Owner

Downstream has made quite some progress, the main blocker was sqlx which has quite a lot of dependencies, and now there only futures-intrusive is blocking. The main dependencies we need to work on fixing are:

* [x]  sqlx: https://github.com/LecrisUT/sqlx-rpmspec

* [ ]  rusty_paserk

* [ ]  rusty_paseto

* [ ]  metrics

* [ ]  metrics-exporter-prometheus

* [ ]  interim

* [ ]  cli-clipboard

* [ ]  parse_duration: Probably need to patch dependency of `num`?

I'm also seeing that axum is failing to build. Looks like we may need to make some inquiries to downstream or patch the dependency down to 0.4.4.

Thanks for your continued work on this!

@LecrisUT
Copy link
Contributor Author

Yeah, that whole dependency tree is being worked on downstream

@LecrisUT
Copy link
Contributor Author

LecrisUT commented May 28, 2024

Status update:

  • sqlx chain is basically finished
  • rusty_paserk, rusty_paseto chain is almost finished
  • metrics chain is almost finished
  • interim, cli-clipboard, parse_duration have a simple dependency chain, should be straightforward to do (if my notes about it are still accurate)

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 4 times, most recently from 7fd7216 to 4cba42b Compare May 30, 2024 09:55
@LecrisUT
Copy link
Contributor Author

LecrisUT commented May 30, 2024

Only remaining issue is with cli-clipboard: allie-wake-up/cli-clipboard#21. We have an alternative

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 3 times, most recently from 7f1a05f to d1e4c1f Compare July 10, 2024 15:31
LecrisUT added 6 commits July 10, 2024 17:57
Signed-off-by: Cristian Le <[email protected]>
Too many build dependencies to handle

Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch from d1e4c1f to 00b4fca Compare July 10, 2024 15:59
@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch from 659e2c8 to b61fb9f Compare July 28, 2024 22:17
LecrisUT added 2 commits July 29, 2024 09:55
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Copy link

Based on your Packit configuration the settings of the lecris/atuin Copr project would need to be updated as follows:

field old value new value
additional_repos [] ['copr://lecris/rust-metrics', 'copr://lecris/rust-sqlx', 'copr://lecris/rust-tonic']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/atuin Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the lecris/atuin Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

5 similar comments
Copy link

Based on your Packit configuration the settings of the lecris/atuin Copr project would need to be updated as follows:

field old value new value
additional_repos [] ['copr://lecris/rust-metrics', 'copr://lecris/rust-sqlx', 'copr://lecris/rust-tonic']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/atuin Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the lecris/atuin Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

Copy link

Based on your Packit configuration the settings of the lecris/atuin Copr project would need to be updated as follows:

field old value new value
additional_repos [] ['copr://lecris/rust-metrics', 'copr://lecris/rust-sqlx', 'copr://lecris/rust-tonic']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/atuin Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the lecris/atuin Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

Copy link

Based on your Packit configuration the settings of the lecris/atuin Copr project would need to be updated as follows:

field old value new value
additional_repos [] ['copr://lecris/rust-metrics', 'copr://lecris/rust-sqlx', 'copr://lecris/rust-tonic']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/atuin Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the lecris/atuin Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

Copy link

Based on your Packit configuration the settings of the lecris/atuin Copr project would need to be updated as follows:

field old value new value
additional_repos [] ['copr://lecris/rust-metrics', 'copr://lecris/rust-sqlx', 'copr://lecris/rust-tonic']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/atuin Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the lecris/atuin Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

Copy link

Based on your Packit configuration the settings of the lecris/atuin Copr project would need to be updated as follows:

field old value new value
additional_repos [] ['copr://lecris/rust-metrics', 'copr://lecris/rust-sqlx', 'copr://lecris/rust-tonic']

Packit was unable to update the settings above as it is missing admin permissions on the lecris/atuin Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the lecris/atuin Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please retrigger the build, once the issue above is fixed.

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch from ac22aa3 to 5300e54 Compare August 27, 2024 13:57
Signed-off-by: Cristian Le <[email protected]>
@SriRamanujam
Copy link
Owner

CI passed!

@LecrisUT
Copy link
Contributor Author

Yeah, we're getting there, you can follow the progress here. I still need some experienced eyes to look over the /etc/profile.d addition because I think it needs to be gated against interactive environment and root user, similar to how Lmod is working. Or make the /etc/profile.d installation optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants