Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

Commit

Permalink
Merge pull request #6 from Sqooba/cc-peer
Browse files Browse the repository at this point in the history
🚑 Make all react related dependencies peer dependencies
  • Loading branch information
ChrisJamesC authored Aug 15, 2017
2 parents 96e083c + 6807c46 commit ea368af
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 16 deletions.
13 changes: 7 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@
"devDependencies": {
"@types/jest": "^20.0.0",
"@types/node": "^8.0.0",
"@types/react": "^16.0.2",
"@types/react-intl": "^2.3.1",
"colors": "^1.1.2",
"commitizen": "^2.9.6",
"condition-circle": "^1.5.0",
Expand All @@ -93,7 +95,9 @@
"mobx-react": "^4.2.2",
"prettier": "^1.4.4",
"prompt": "^1.0.0",
"react": "^15.6.1",
"react-dom": "^15.6.1",
"react-intl": "^2.3.0",
"replace-in-file": "^2.5.0",
"rimraf": "^2.6.1",
"rollup": "^0.42.0",
Expand All @@ -112,15 +116,12 @@
"validate-commit-msg": "^2.12.2"
},
"dependencies": {
"@types/react": "^15.0.38",
"@types/react-intl": "^2.3.1",
"format-message": "^5.2.0",
"react": "^15.6.1",
"react-intl": "^2.3.0"
"format-message": "^5.2.0"
},
"peerDependencies": {
"mobx": "^3.0.0",
"mobx-react": "^4.0.0",
"react": "^15"
"react": "^15.6.1",
"react-intl": "^2.3.0"
}
}
6 changes: 4 additions & 2 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ export default {
],
sourceMap: true,
// Indicate here external modules you don't wanna include in your bundle (i.e.: 'lodash')
external: ['mobx-react', 'mobx'],
external: ['mobx-react', 'mobx', 'react-intl', 'react'],
globals: {
'mobx': 'mobx',
'mobx-react': 'mobxReact'
'mobx-react': 'mobxReact',
'react-intl': 'react-Intl',
'react': 'react'
},
plugins: [
// Allow bundling cjs modules (unlike webpack, rollup doesn't understand cjs)
Expand Down
12 changes: 4 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@
version "2.3.1"
resolved "https://registry.yarnpkg.com/@types/react-intl/-/react-intl-2.3.1.tgz#d036dbe54f6ef29f2a150ed303a84f1693ddf905"

"@types/react@^15.0.38":
version "15.6.1"
resolved "https://registry.yarnpkg.com/@types/react/-/react-15.6.1.tgz#497f7228762da4432e335957cb34fe9b40f150ae"
"@types/react@^16.0.2":
version "16.0.2"
resolved "https://registry.yarnpkg.com/@types/react/-/react-16.0.2.tgz#0b31a73cdde6272b719e5b05a7df6d1e2654a804"

"@types/shelljs@^0.7.0":
version "0.7.4"
Expand Down Expand Up @@ -1529,14 +1529,10 @@ [email protected]:
version "0.3.5"
resolved "https://registry.yarnpkg.com/i/-/i-0.3.5.tgz#1d2b854158ec8169113c6cb7f6b6801e99e211d5"

[email protected]:
[email protected], iconv-lite@~0.4.13:
version "0.4.13"
resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.13.tgz#1f88aba4ab0b1508e8312acc39345f36e992e2f2"

iconv-lite@~0.4.13:
version "0.4.18"
resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.18.tgz#23d8656b16aae6742ac29732ea8f0336a4789cf2"

indent-string@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/indent-string/-/indent-string-2.1.0.tgz#8e2d48348742121b4a8218b7a137e9a52049dc80"
Expand Down

0 comments on commit ea368af

Please sign in to comment.