Dev/19: ServiceInstanceListSupplierBuilder design basic implementation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricky587
reviewed
Nov 6, 2020
Ricky587
reviewed
Nov 6, 2020
Ricky587
reviewed
Nov 6, 2020
Ricky587
reviewed
Nov 6, 2020
commons/client/loadbalancer/supplier/service_instance_list_supplier.py
Outdated
Show resolved
Hide resolved
|
btw what happened to your pre-commit check? |
@Ricky587 Since my PRs are sequential, dev/20 based on dev/19, dev/19 based on dev/17, dev/17 based on main BTW the pre-commit hook works very well locally, it's really convenient. |
Johnny850807
requested review from
Chaoyuuu,
ck6990ck6990,
Daniel1147,
Ricky587 and
Ssu-Tsen
Johnny850807
requested review from
benbenbang and
Ricky587
and removed request for
woolninesun and
benbenbang
benbenbang
reviewed
Nov 7, 2020
|
Revision Done |
|
LGTM for pythonic |
|
Go go ;) |
ck6990ck6990
pushed a commit
that referenced
this pull request
Nov 18, 2020
#24) * 🍺 implement DiscoveryClient design * Add more comments * Modify some functional operation concerning performance * 📝 add typing and docstrings * Make some fields private * Fix naming * pending discussion: next+filter vs list comprehension * 🎨 Add type checking syntax * improve filter_get_first utils * ✨ FixedServiceInstanceListSupplier completed * ✨ CachingServiceInstanceListSupplier completed * 🎨 Add type checking syntax * 🎨 Add NoneTypeError and some type checking * 🍺 implement DiscoveryClient design * Add more comments * Modify some functional operation concerning performance * 📝 add typing and docstrings * Make some fields private * Fix naming * pending discussion: next+filter vs list comprehension * 🎨 Add type checking syntax * improve filter_get_first utils * 🚚 Modify the package layout, rooted from spring_cloud * add utils/validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ServiceInstanceListSupplierBuilderimplementationDelegatingServiceInstanceListSupplierandCachingServiceInstanceListSupplierCacheManagerbasic implementation helps handle caching get/put in a fluent way, for examplecache_manager.get(CACHE_NAME).on_cache_miss(lambda: retrieve_value())CacheManageris used byCachingServiceInstanceListSupplier