Feat: show project tributes #161
Conversation
…t-token into feat/get-project-tributes # Conflicts: # frontend/src/graph/getProjects.js
✅ Deploy Preview for sporosdaoapp-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…t-token into feat/get-project-tributes # Conflicts: # frontend/src/pages/Projects/ProjectDetails.tsx
|
Nice @cptnanon ! Very clean code ! On standby to review and test thoroughly when all checks are green. |
cptnanon
changed the title
# Conflicts: # frontend/yarn.lock
There was a problem hiding this comment.
First of all, very nice work! Clean and readable code!
The tribute history page seems to work well.
Next, the failing test seems to be doing their job.
I tested manually the UI and found out a couple of things that need to be fixed:
- On Projects page, the tribute button no longer works. It goes to tribute history instead. Probably a simple fix. Add a View Past Tributes button to distinguish clearly the two functions. The overall card click can be view past tributes. That seems like a reasonable default. Unless users complain.
- The /tribute route itself is now broken. Instead of opening the Tribute form for submitting a new tribute to the project it goes to the historical tributes page.
Both 1&2 might be easily fixable with one line change here:
https://github.com/SporosDAO/sweat-token/pull/161/files#diff-e56cb91573ddb6a97ecd071925fe26504bb5a65f921dc64c63e534162950e1ebR18
To be safe, we should cover 1&2 with test cases.
frontend/src/App.tsx
Outdated
| @@ -14,6 +15,7 @@ function App() { | |||
| <Route path="dao/chain/:chainId/address/:daoId" element={<Dao />}> | |||
| <Route path="projects" element={<Projects />}></Route> | |||
| <Route path="projects/propose" element={<ProjectProposal />}></Route> | |||
| <Route path="projects/:projectId" element={<ProjectDetails />}></Route> | |||
There was a problem hiding this comment.
I think this route hides the next line and /tribute page is unreachable. Would be good to write some tests for these cases.
#93