Correct 'ifSucessful' to DataTransactionResult#ifSuccessful #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Report it in #1000 instead, please! |
|
No seeing as this is a breaking change it is not suited to the minor issue list. |
|
eh, why not merge it then? |
dualspiral
suggested changes
May 30, 2017
| @@ -330,7 +330,7 @@ public boolean isSuccessful() { | |||
| * | |||
| * @param consumer The consumer to call | |||
| */ | |||
| public void ifSucessful(Consumer<List<ImmutableValue<?>>> consumer) { | |||
There was a problem hiding this comment.
This method should be deprecated (with a @deprecated tag explaining why in the javadocs), rather than outright removed, and call the correct method - a bit like what was done here. We'd then remove it two API versions up the road (so, if it was pulled now, we would want to deprecate for API 7, which we'd then remove in API 8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple spelling mistake fix.