Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require ext-imagick #83

Closed
wants to merge 1 commit into from
Closed

require ext-imagick #83

wants to merge 1 commit into from

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Mar 2, 2024

Since we have a hard dependency on imagick, we should require it.

Since we have a hard dependency on imagick, we should require it.
@Spomky
Copy link
Member

Spomky commented Mar 2, 2024

No, there is no hard dependency. The image processor is optional.

@tacman
Copy link
Contributor Author

tacman commented Mar 3, 2024

if we implement #84, we can auto-detect imagick and add the

     image_processor: 'pwa.image_processor.imagick'

line if it exists, otherwise we can add a comment there for developers to know how to use it.

On a somewhat related note, the favicon generator library now supports php 8.3

@tacman tacman closed this Mar 3, 2024
@tacman tacman deleted the patch-3 branch March 3, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants