Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pwa:create:config command #84

Open
tacman opened this issue Mar 2, 2024 · 1 comment
Open

add pwa:create:config command #84

tacman opened this issue Mar 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tacman
Copy link
Contributor

tacman commented Mar 2, 2024

Description

I'd like to quickly create the config/packages/pwa.yaml command, as the first thing I do when adding pwa capabilities via this awesome bundle is copy from one of my existing projects and tweak the name and description.

I imagine that pwa.yaml is going to grow in complexity, the more programmers can put in the YAML, the less javascript they have to write in the service worker. In particular, configuring the caching strategies is tricky in javascript, which is why I love that this bundle is doing all the hard work.

I was thinking about writing a pwa-helper-bundle where I could play around with ideas like this and the route attribute parsing. Eventually the "extra" would move into the core bundle (this one) as you see fit.

extra could also include some twig components, like an install button and maybe some debugging. Once it works, we can move it to here.

Example

bin/console php:create:config --name="HackerNews PWA" --description="A HackerNews implementation based on Symfony" 
@Spomky Spomky self-assigned this Mar 2, 2024
@Spomky Spomky added this to the 1.1.0 milestone Mar 2, 2024
@Spomky Spomky added the enhancement New feature or request label Mar 2, 2024
@tacman
Copy link
Contributor Author

tacman commented Mar 4, 2024

I started playing around with this, and wow, what a config file! In fact, I think I found a Symfony bug while trying to understand it.

It's probably not common, and it might not even be possible, but do you think there's any value in splitting up the manifest and service worker configuration?

Regardless, this bundle doesn't have a recipe yet, if it did, what would be a minimal yaml file to create? Most of the defaults work fine, but obviously name, short_name and description need to change. I also had an idea about an icons and screenshots directory, rather than listing each of them.

@Spomky Spomky modified the milestones: 1.1.0, 1.2.0 Mar 5, 2024
@Spomky Spomky modified the milestones: 1.2.0, 2.0.0 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants