Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert durations to Float before computing percentage #1358

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Convert durations to Float before computing percentage #1358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/view_models/effort_analysis_row.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,16 @@ def time_in_aid_over_under(round_to: 1.second)
end

def combined_time_over_under(round_to: 1.second)
return nil unless segment_time_over_under && time_in_aid_over_under
return nil unless segment_time_over_under.present? && time_in_aid_over_under.present?

segment_time_over_under.round_to_nearest(round_to) + time_in_aid_over_under.round_to_nearest(round_to)
end

# @return [Float, nil]
def segment_over_under_percent
segment_time_over_under && segment_time_typical && segment_time_over_under / segment_time_typical
return nil unless segment_time_over_under.present? && segment_time_typical.present?

segment_time_over_under.to_f / segment_time_typical.to_f
end

private
Expand Down
Loading