Wrap medicine motion estimation #3552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgarcia
commented
Nov 27, 2024
Comment on lines
+49
to
+62
| if rigid: | ||
| # force one bin | ||
| num_depth_bins = 1 | ||
| else: | ||
|
|
||
| # we use the spatial window mechanism only to estimate the number one spatial bins | ||
| dim = ["x", "y", "z"].index(direction) | ||
| contact_depths = recording.get_channel_locations()[:, dim] | ||
|
|
||
| deph_range = max(contact_depths) - min(contact_depths) | ||
| if win_margin_um is not None: | ||
| deph_range = deph_range - 2 * win_margin_um | ||
| num_depth_bins = max(int(np.round(deph_range / win_scale_um)), 1) | ||
| print("num_depth_bins", num_depth_bins) |
There was a problem hiding this comment.
@nwatters01 this is the main zone where we need to discuss.
I think that windows should come with the probe boundaries +/- margin not by the the spike depth limits.
Otherwise the number of spatial windows will depend on the recording itself and could vary from one recording to another.
|
FYI @samuelgarcia it appears the method is medicine not medecine--> probably better to change files names etc too. see here |
alejoe91
requested changes
Nov 28, 2024
| from .motion_utils import get_spatial_windows | ||
|
|
||
|
|
||
| class MedecineRegistration: |
There was a problem hiding this comment.
Suggested change
| class MedecineRegistration: | |
| class MedicineRegistration: |
| class MedecineRegistration: | ||
| """ """ | ||
|
|
||
| name = "medecine" |
There was a problem hiding this comment.
Suggested change
| name = "medecine" | |
| name = "medicine" |
| @@ -11,6 +11,7 @@ | |||
| from .decentralized import DecentralizedRegistration | |||
| from .iterative_template import IterativeTemplateRegistration | |||
| from .dredge import DredgeLfpRegistration, DredgeApRegistration | |||
| from .medecine import MedecineRegistration | |||
There was a problem hiding this comment.
Suggested change
| from .medecine import MedecineRegistration | |
| from .medicine import MedicineRegistration |
| IterativeTemplateRegistration, | ||
| DredgeLfpRegistration, | ||
| DredgeApRegistration, | ||
| MedecineRegistration, |
There was a problem hiding this comment.
Suggested change
| MedecineRegistration, | |
| MedicineRegistration, |
samuelgarcia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nwatters01 @alejoe91 @yger
here the wrapper which also need this PR
jazlab/medicine#2