Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream_mode as extra_requirements for NWB when streaming #3548

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Add stream_mode as extra_requirements for NWB when streaming #3548

merged 2 commits into from
Dec 11, 2024

Conversation

alejoe91
Copy link
Member

Fixes #3540

@alejoe91 alejoe91 added the extractors Related to extractors module label Nov 28, 2024
h-mayorquin
h-mayorquin approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am curios on what the performance will be with this.

This will throw an error if someone tries to use ros3 I think but we are getting rid of that.

@alejoe91 alejoe91 merged commit 4ed068a into SpikeInterface:main Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

@samuelgarcia samuelgarcia Awaiting requested review from samuelgarcia

Assignees
No one assigned
Labels
extractors Related to extractors module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing requirements in docker container for spike sorting with kilosort3
2 participants
@alejoe91 @h-mayorquin