-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow export_report
to run without waveforms
#3493
Allow export_report
to run without waveforms
#3493
Conversation
I think this is an improvement. Another request we should think about is to have more flexibility in selecting what to plot in general. There are complaints about the slowness of making the summary when you only want some features to be saved. So something like this could be extended to help speed things up for people. |
Good idea. thanks Chris. |
Mmm, good idea. So at the moment we include 5 widgets. Your suggestion would be to allow the user to select which ones they'd like, and we format the report appropriately? Sounds doable (and extendable for other widgets!) in another PR. |
agreed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @chrishalcrow this is really cool, the export report is a great feature and making it more flexible is very useful. Also agree that custom selecting of subplots would be very nice (in another PR).
I ran it and it all worked nicely. Some small changes suggested, apologies some are outside this diff as I was reading the code in another editor, but I guess now would be a good time to change them.
Thanks @JoeZiminski - will take a look on Monday! |
All updated - also fixed a column counting issue that occurred when correlograms and spike_amplitudes were on, but waveforms were off. Also added in a check for |
yeah the correlograms are only calculated for templates deemed similar enough. That's annoyed me in the past, but I understand why it is there. |
Hello, could this be merged please(@samuelgarcia )? Just to sum up, here is every possible report output, made from
then...
|
@chrishalcrow @zm711 I pushed an update that removes the need to compute Tested on my side and works like a charm! |
Beautiful - works on my side too. |
Small edit to
export_report
so that it will generate a report without waveforms.When we're being speedy, we often don't compute or don't copy over waveforms. This PR just changes
export_report
so that it does/doesn't include theUnitWaveformDensityMapWidget
if the sorting_analyzer does/doesn't have waveforms computed.A unit report without waveforms:
computed using