Improve merging and iterative merging #3487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
| merging_methods = ["circus", "auto_merges"] | ||
|
|
||
|
|
||
| def create_sorting_analyzer_with_templates(sorting, recording, templates, remove_empty=True): |
There was a problem hiding this comment.
If this is a need we should have this function somewhere else
| return sa | ||
|
|
||
|
|
||
| def merging_circus( |
| ) | ||
|
|
||
|
|
||
| def merge_spikes( |
There was a problem hiding this comment.
I think we should use only the
merged_analyzer = auto_merge(analyzer, ...)
which I have push in #3435 because it do the same.
The final sorting is accessed by merged_analyzer.sorting.
|
This one is also almost good after the discussion we had yesterday @samuelgarcia @alejoe91. Now the auto_merge_units() function can handle lists of presets, and the benchmark is also there and working. Some questions:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch depends on #3435 , and adds the possibility to benchmark only meta merging, i.e. the final steps of a sorting procedure. Such step is crucial in the context of drift-corrected recordings. Note that it will replace #2934 that will be closed, since now the code is easier to read, cleaner, and more in line with @samuelgarcia point of view. It can still be discussed however, to know if we should do a proper merging step for the sortingcomponents. I think we should, because several options could be tried and benchmark.
Functions to split by times and/or amplitudes have been rewritten without any dependencies, in a separate file as requested in #2934 (splitting_tools.py in generation)