Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units aggregation preserve unit ids of aggregated sorters #3180

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Units aggregation preserve unit ids of aggregated sorters #3180

merged 3 commits into from
Jul 12, 2024

Conversation

h-mayorquin
Copy link
Collaborator

This should close #3152

@h-mayorquin h-mayorquin added the core Changes to core module label Jul 10, 2024
@h-mayorquin h-mayorquin self-assigned this Jul 10, 2024
@h-mayorquin h-mayorquin changed the title Units aggregation should preserve unit ids Units aggregation preserve unit ids of aggregated sorters Jul 10, 2024
@alejoe91 alejoe91 added this to the 0.101.0 milestone Jul 11, 2024
zm711
zm711 reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me now!

@alejoe91 alejoe91 merged commit 53933e6 into SpikeInterface:main Jul 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 left review comments

@alejoe91 alejoe91 alejoe91 approved these changes

Assignees

@h-mayorquin h-mayorquin

Labels
core Changes to core module
Projects
None yet
Milestone
0.101.0
Development

Successfully merging this pull request may close these issues.

Unit aggregation should preserve unit ids.
3 participants
@h-mayorquin @alejoe91 @zm711