Better error message for BaseExtractor.load()
#3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alejoe91
reviewed
Jul 9, 2024
zm711
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Even with the grammar improvement I have no clue what the problem with the base_folder is. At least for the file_path you're saying that based on your tests it doesn't seem to exist. But just telling me that I gave a base_folder doesn't tell me how to fix my problem.
And the error rule for Heberto is it must be actionable.
|
Github seems to have some connection errors today. |
zm711
reviewed
Jul 9, 2024
Co-authored-by: Zach McKenzie <[email protected]>
for more information, see https://pre-commit.ci
|
I think pre-commit broke this :/ No--really we should have put parentheses around the string. That's my bad in my suggestion. I can't blame pre-commit. |
|
Should be solved int the last commit. |
Co-authored-by: Chris Halcrow <[email protected]>
chrishalcrow
approved these changes
Jul 11, 2024
alejoe91
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title, related to issue #3148