Add streaming extractor tests to main test script #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
samuelgarcia
reviewed
Jul 3, 2024
| @@ -309,7 +309,7 @@ class IblSortingExtractor(BaseSorting): | |||
| name = "ibl" | |||
| installation_mesg = "IBL extractors require ibllib as a dependency." " To install, run: \n\n pip install ibllib\n\n" | |||
|
|
|||
| def __init__(self, pid, good_clusters_only=False, load_unit_properties=True, one=None): | |||
| def __init__(self, pid: str, good_clusters_only: bool = False, load_unit_properties: bool = True, one=None): | |||
There was a problem hiding this comment.
Sorry Sam, needed a cange to trigger the CI : P
samuelgarcia
approved these changes
Jul 3, 2024
|
merci a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort in #3100
Two improvements for the streaming extractors:
I am thinking that maybe we can only one test for all extractors and not have a separate sets of tests but I am less sure about IBL which was problematic at some point.
Maybe let's keep it like this for a while and then we can change in the future if does not give problems for a while.