Add macos and windows to cache cron jobs #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
added
testing
alejoe91
approved these changes
Jun 25, 2024
JoeZiminski
pushed a commit
to JoeZiminski/spikeinterface
that referenced
this pull request
Jun 26, 2024
Add macos and windows to cron jobs for caching testing data
JoeZiminski
pushed a commit
to JoeZiminski/spikeinterface
that referenced
this pull request
Jun 26, 2024
Add macos and windows to cron jobs for caching testing data
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things into this PR. As discussed with everyone the impact of caching the virtual environment is minimal and the impact of caching on the datasets is too large. The first one is 3 vs 5 minutes whereas the latter one is 3 vs 50 minutes.
Plus, there is already caching functionality in the setup-python action. I can test that after we get this caching running.
This PR enables caching for windows and macos.
Hopefully this works OK for windows when datasets are not downloaded file by file otherwise I will need a hack for windows : )